search

cedaro / grunt-wp-i18n

Internationalize WordPress themes and plugins with Grunt.
MIT License
160 stars 25 forks source link

Fix keywords list common header default value #33

Closed GaryJones closed 10 years ago

GaryJones commented 10 years ago

I spent considerable time looking into what this deciphers as, and most themes and plugins have it wrong. The string that this commit replaces included deprecated functions that no-one should be using, and didn't include the escaping functions. That means Poedit would not be picking up on strings wrapped in valid i18n functions.

This new string can be confirmed with the data at https://github.com/stephenharris/grunt-checktextdomain/blob/6e98c54be3058e4c510a7c0e564457485df34006/Gruntfile.js#L13 though that includes the custom d flag, that is something unique to grunt-checktextdomain.

bradyvercher commented 10 years ago

Awesome, nice work! Thanks for looking into and correcting this, @GaryJones