search

cedaro / grunt-wp-i18n

Internationalize WordPress themes and plugins with Grunt.
MIT License
160 stars 25 forks source link

"updateTimestamp: false" is not working properly #68

Closed rahulv3a closed 6 years ago

rahulv3a commented 8 years ago

First of thank you such an awesome plugin :+1:

There is just one little thing that bugs me. POT-Creation-Date is updated every time even if there are no changes. This is a bit annoying in a version controlled environment, where you don't want to see unnecessary changes.

Edit: Just found updateTimestamp in the documentations. I think it is exactly what I'm looking for. But when I tried it, it stops updating POT-Creation-Date, altogether even if there changes in the translation strings.

brianhogg commented 7 years ago

I have the issue where updateTimestamp: false in the Gruntfile is just ignored, and the timestamp is updated every time even if no strings have changed.

GaryJones commented 7 years ago

FWIW, this is applied here.

bradyvercher commented 6 years ago

There has been a test for the updateTimestamp option for quite awhile and the underlying node module has its own tests.

My only guess is that this was an issue with an earlier version, but if anyone is still having an issue, please feel free to reopen with more information -- a failing test would be even better.