cedaro / grunt-wp-i18n

Internationalize WordPress themes and plugins with Grunt.
MIT License
160 stars 25 forks source link

Bump grunt to ~1.0 #69

Closed robneu closed 7 years ago

robneu commented 7 years ago

I recently noticed that a fair amount of my install warning nags could be traced back to this, so I was wondering if it would be possible to bump this up?

I tested a bit on my local and nothing seemed to break, but I don't know how much that really means...

Might also be worth bumping these, but I didn't want any incompatibilities in them to prevent this from being merged:

 async                    ~0.9.0  →  ~2.1.4
 gettext-parser           ~1.1.0  →  ~1.2.2
 underscore.string        ~3.0.3  →  ~3.3.4
 grunt-contrib-clean      ~0.6.0  →  ~1.0.0
 grunt-contrib-copy       ~0.8.0  →  ~1.0.0
 grunt-contrib-jshint    ~0.11.1  →  ~1.1.0
 grunt-contrib-nodeunit   ~0.4.1  →  ~1.0.0
 underscore               ~1.8.2  →  ~1.8.3
robneu commented 7 years ago

Looks like a few of the other deps are asking for ~0.4.0. 🤔😭

I'll try bumping them up and see what Travis has to say about it...

robneu commented 7 years ago

🎉

What say you, Brady? Does the node engine need to be increased as well?

bradyvercher commented 7 years ago

According to #61, I was planning to extract the core into a separate node module and release 1.0. It should be ready to go, so let me run a few tests, update the versions in that branch, and see about getting that released.

robneu commented 7 years ago

Ah, alrighty. That looks even better. 😍

bradyvercher commented 7 years ago

I went ahead and pushed out 1.0.0. Let me know if anything blows up. 💣

robneu commented 7 years ago

No explosions on my end. So much faster too. A+++ would download again.