search

cedaro / satispress

Expose installed WordPress plugins and themes as Composer packages.
500 stars 49 forks source link

Remove dist from archive_from_source excludes #100

Closed TimothyBJacobs closed 5 years ago

TimothyBJacobs commented 5 years ago

We ship a plugin that includes a dist directory in the plugin root that contains the built version of our JS files.

https://github.com/cedaro/satispress/blob/af03db0e153945cee2c00f90498ebf0e5e200e73/src/Archiver.php#L75

The dist directory is intentionally removed. I can see why the other directory names are excluded as they are dev files, but isn't dist usually for built files that are necessary for the plugin to run?

bradyvercher commented 5 years ago

/dist is where all of my themes and plugins compile and save the release artifact for distribution. I'm not totally opposed to removing it from the default excludes if I'm the only one using it for that.

TimothyBJacobs commented 5 years ago

Ah, interesting.

Would maybe supporting .distignore work? https://developer.wordpress.org/cli/commands/dist-archive/

bradyvercher commented 5 years ago

Yeah, that would probably work and would be easier to use than the filter.