cedaro / satispress

Expose installed WordPress plugins and themes as Composer packages.
508 stars 51 forks source link

Superflous/confusing line #123

Closed BrianHenryIE closed 4 years ago

BrianHenryIE commented 4 years ago

I spent far too much time looking at this line before realising it doesn't do anything!

$user_id is already false here.

bradyvercher commented 4 years ago

I can't recall if that was added for a specific reason or if it was just to be explicit what the return value should be (without returning early), but some callbacks do pass unexpected data into that filter. I think null is the only one that would ever make it that far and it wouldn't be handled any different once it bubbles back up to WordPress, so it's probably safe to remove.