cedaro / satispress

Expose installed WordPress plugins and themes as Composer packages.
500 stars 48 forks source link

Is there a problem with packagist's version? #144

Closed patrick-leb closed 3 years ago

patrick-leb commented 3 years ago

I'm sorry if I'm being completely dumb right now but here is what I get:

root@source:/var/www/html/wp_sources# rm -rf web/app/plugins/satispress/
root@source:/var/www/html/wp_sources# sudo -u wpcli composer update cedaro/satispress --no-cache
Loading composer repositories with package information
Updating dependencies
Nothing to modify in lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Downloading cedaro/satispress (v0.7.0)
  - Installing cedaro/satispress (v0.7.0): Extracting archive
Generating optimized autoload files
10 packages you are using are looking for funding.
Use the `composer fund` command to find out more!
root@source:/var/www/html/wp_sources# cat web/app/plugins/satispress/satispress.php | grep VERSION
const VERSION = '0.6.0';

I checked your 0.7.0 release here on GitHub and the version is CORRECT to 0.7.0.

So then I checked .lock:

 "packages": [
        {
            "name": "cedaro/satispress",
            "version": "v0.7.0",
            "source": {
                "type": "git",
                "url": "https://github.com/cedaro/satispress.git",
                "reference": "317a2dc20cdfce098efec5e7652af479903c4f5a"
            },
            "dist": {
                "type": "zip",
                "url": "https://api.github.com/repos/cedaro/satispress/zipball/317a2dc20cdfce098efec5e7652af479903c4f5a",
                "reference": "317a2dc20cdfce098efec5e7652af479903c4f5a",
                "shasum": ""
            },
            "require": {
                "cedaro/wp-plugin": "^0.4.0",
                "composer/installers": "^1.0",
                "composer/semver": "^3.2",
                "php": "^7",
                "pimple/pimple": "^3.2",
                "psr/container": "^1.0",
                "psr/log": "^1.0"
            },
[...]

And sure enough that Zipball is version 0.6.0

I tried to delete the lock file as well and start from scratch but wouldn't change.

I don't know if packagist cached the wrong version or if I'm being a complete idiot and I need another coffee lol

bradyvercher commented 3 years ago

Someone notified me last night that I somehow hadn't merged develop into master, so that's likely the problem. I've updated the tag here on GitHub, but I'll go ahead and push out a new release so Composer will install the latest version.

bradyvercher commented 3 years ago

@patrick-leb I pushed out a new release, so Composer should install the correct version now.

Also, thanks a ton for the sponsorship! It's much appreciated and every little bit helps.

patrick-leb commented 3 years ago

Yep all good! that fixed the issue. I was starting to doubt everything I knew about composer... LOL

And my pleasure for the sponsorship, I can't wait to be able to do more :)