cedaro / satispress

Expose installed WordPress plugins and themes as Composer packages.
500 stars 48 forks source link

Error when updating composer #164

Closed martin-josef closed 2 years ago

martin-josef commented 2 years ago

Hello, I've been using satispress (successfully!) for quite some time and it has really helped my way of working with bedrock. I now run the repository locally as I don't need it to be exposed to the internet.

I get the following error:

Warning: Accessing satis.test over http which is an insecure protocol.
http://satis.test/satispress could not be fully loaded ("http://satis.test/satispress/packages.json" does not contain valid JSON
Parse error on line 1:
<br /><b>Fatal erro
^
Expected one of: 'STRING', 'NUMBER', 'NULL', 'TRUE', 'FALSE', '{', '['), package information was loaded from the local cache and may be out of date

I have reset (wp db reset & site empty) the satispress WordPress install, it hasn't changed.

Kind regards, Martin

raphaelparent commented 2 years ago

I also get this when I try to run an update, the difference being I'm running it publicly over https

https://packages.raphparent.website/satispress could not be fully loaded ("https://packages.raphparent.website/satispress/packages.json" does not contain valid JSON
Parse error on line 1:
object(SatisPress\HT
^
Expected one of: 'STRING', 'NUMBER', 'NULL', 'TRUE', 'FALSE', '{', '['), package information was loaded from the local cache and may be out of date

And when I try to access the json file this is what I get

object(SatisPress\HTTP\Response)#1450 (3) {
  ["body":protected]=>
  object(SatisPress\HTTP\ResponseBody\JsonBody)#1451 (1) {
    ["data":protected]=>
    array(1) {
      ["packages"]=>
      array(1) {
        ["raphparent-packages/advanced-custom-fields-pro"]=>
        array(1) {
          ["5.10.2"]=>
          array(9) {
            ["name"]=>
            string(46) "raphparent-packages/advanced-custom-fields-pro"
            ["version"]=>
            string(6) "5.10.2"
            ["version_normalized"]=>
            string(8) "5.10.2.0"
            ["dist"]=>
            array(3) {
              ["type"]=>
              string(3) "zip"
              ["url"]=>
              string(80) "https://packages.raphparent.website/satispress/advanced-custom-fields-pro/5.10.2"
              ["shasum"]=>
              string(40) "d15dc3b202e1cd6366f32a980dc1f246f48685a3"
            }
            ["require"]=>
            array(1) {
              ["composer/installers"]=>
              string(4) "^1.0"
            }
            ["type"]=>
            string(16) "wordpress-plugin"
            ["authors"]=>
            array(2) {
              ["name"]=>
              string(16) "Delicious Brains"
              ["homepage"]=>
              string(36) "https://www.advancedcustomfields.com"
            }
            ["description"]=>
            string(69) "Customize WordPress with powerful, professional and intuitive fields."
            ["homepage"]=>
            string(36) "https://www.advancedcustomfields.com"
          }
        }
      }
    }
  }
  ["headers":protected]=>
  array(1) {
    ["Content-Type"]=>
    string(31) "application/json; charset=UTF-8"
  }
  ["status_code":protected]=>
  int(200)
}
{"packages":{"raphparent-packages\/advanced-custom-fields-pro":{"5.10.2":{"name":"raphparent-packages\/advanced-custom-fields-pro","version":"5.10.2","version_normalized":"5.10.2.0","dist":{"type":"zip","url":"https:\/\/packages.raphparent.website\/satispress\/advanced-custom-fields-pro\/5.10.2","shasum":"d15dc3b202e1cd6366f32a980dc1f246f48685a3"},"require":{"composer\/installers":"^1.0"},"type":"wordpress-plugin","authors":{"name":"Delicious Brains","homepage":"https:\/\/www.advancedcustomfields.com"},"description":"Customize WordPress with powerful, professional and intuitive fields.","homepage":"https:\/\/www.advancedcustomfields.com"}}}}
raphaelparent commented 2 years ago

@martin-josef reverting back to 1.0.0 seems to fix the issue on my end.

Edit: Using the latest version (1.0.2) with PHP 7.4 seems to also work. This seems to be an issue with PHP 8.

bradyvercher commented 2 years ago

As far as I can tell, the original issue is because Composer requires HTTPS by default.

The other issues should be solved in #155 and #165.