search

cedaro / satispress

Expose installed WordPress plugins and themes as Composer packages.
508 stars 51 forks source link

Check Package::is_installed() before calling methods for installed packages #68

Closed bradyvercher closed 6 years ago

bradyvercher commented 6 years ago

Does something like this take care of the undefined method violations in #66?

bradyvercher commented 6 years ago

I think the latest commits should clear those issues up.

bradyvercher commented 6 years ago

Figures I'd introduce a couple of bugs trying to fix this. I'll get it worked out when I get a bit of time to take a closer look.

I did download PhpStorm to play around and it looks like just doing a $package instanceof InstalledPackage check clears these up.

bradyvercher commented 6 years ago

I think the latest commit should clear up these inspection violations. If so, this can be squashed before merging.

bradyvercher commented 6 years ago

@GaryJones Did that last commit clean things up?

GaryJones commented 6 years ago

Haven't got around to checking this one - tab is still open as a reminder though :-)

GaryJones commented 6 years ago

I've still not had a chance to check, but feel free to go ahead and merge - I'll follow up separately if anything is outstanding.

bradyvercher commented 6 years ago

Sounds good. I have a couple more things I'd like to look into before hopefully getting a release out soon. Thanks for following up!