search

cedaro / simple-image-widget

A simple WordPress image widget.
32 stars 19 forks source link

add alt & title attribute on link. #11

Closed berteh closed 9 years ago

berteh commented 9 years ago

I suggest adding an alt (&title) attribute on the link, from either the link_text or title field. thanks for considering inclusion in your nice plugin.

bradyvercher commented 9 years ago

Hi @berteh, thanks for the PR. However, I don't think incorporating either of those attributes on the link tag is a best practice. Feel free to provide some links for why they should be included and I'll be happy to take another look.

The alt attribute isn't a valid for link tags and the title attribute doesn't have any benefits. Here's some more reading on the latter.