search

cedbossneo / openmower-gui

28 stars 17 forks source link

Merge mower config changes via crudini #29

Closed olliewalsh closed 5 months ago

olliewalsh commented 5 months ago

Use crudini to merge mower_config changes. This should do a reasonably good job updating existing entries in-place and appending new entries at the end. Not completely fool-proof as this isn't really what crudini is designed for but I believe it should always result in a valid and correct conf.

Fixes https://github.com/cedbossneo/openmower-gui/issues/26

cedbossneo commented 5 months ago

Done in go

karlranseierausrom commented 4 months ago

I tried it today.

The following lines are lost:

export OM_AUTOMATIC_START="true" export OM_GPS_BAUDRATE="921600" export OM_HARDWARE_VERSION="0_13_X" export OM_MOWER_ESC_TYPE="xesc_mini" export OM_MOWER="YardForce500"

is that intended? With saving the config through gui a restart of openmower fails.

olliewalsh commented 4 months ago

Tried what? This PR wasn't merged, @cedbossneo used a different approach. Should raise a new issue if something isn't working with that

karlranseierausrom commented 4 months ago

Sorry for the confusion. I read in the News, that changing config should Work now. I found this PR but No other, so concluded wrong, that this was the solution. So Yesterday I pulled the Main Version of gui, but there is still a Problem with saving the config.