search

cedbossneo / openmower-gui

28 stars 18 forks source link

3 things to improve with map editor #50

Open houk001 opened 4 months ago

houk001 commented 4 months ago
  1. Functionality of moving whole area move to additional icon when pressed this action is possible, i move whole area couple of time when I want to move one dot.
  2. When saving map.bag create backup of old map.bag. One copy is enough.
  3. Ability to select several dots and move them with alignment.
fallingcats commented 4 months ago
  1. Functionality of moving whole area move to additional icon when pressed this action is possible, i move whole area couple of time when I want to move one dot.

Agreed.

  1. When saving map.bag create backup of old map.bag. One copy is enough.

openmower-gui doesn't directly save to the map.bag (in fact it doesn't even have access to it when run in a container), it only sends commands to modify the map to the ros map service

  1. Ability to select several dots and move them with alignment.

If I understand that correctly, that's already possible with the latest version. Click on an area twice, hold shift and drag a selection box. To update, run sudo podman auto-update

houk001 commented 4 months ago

Shift is working, thank you. Next is select couple of dots and alignment this dots by the line of first and last dot selected, this will be cool option to correct map after recording area.

fallingcats commented 4 months ago

Shift is working, thank you. Next is select couple of dots and alignment this dots by the line of first and last dot selected, this will be cool option to correct map after recording area.

If you just want a straight line you can also go ahead and just delete all selected points. As a bonus, having less points also makes pretty much everything map related faster

houk001 commented 4 months ago

Yes, i know but deleted points cause mower to drive fast and i have some part of outline that i want to drive slow, because of bumps or driving very close to items.

fallingcats commented 4 months ago

Yes, i know but deleted points cause mower to drive fast and i have some part of outline that i want to drive slow, because of bumps or driving very close to items.

I was under the impression that it drives fast on straight lines and slower if it isn't. I don't think it's related to the number of points, are you absolutely certain? Once an area is sliced the polygon shouldn't matter after all

houk001 commented 4 months ago

I have mower running slow when i record drive slow. After deletion 200 dots mower drive this outline area fast. Maybe points was slightly not in line.

Jahnkeanater commented 2 months ago

I can't get the merge tool to save a map at all. It says saving failed then corrupts the map file.