cedbossneo / openmower-gui

28 stars 18 forks source link

Editing reliably corrupts my map #51

Open fallingcats opened 3 months ago

fallingcats commented 3 months ago

I'm not sure it this it common or specifically a problem with my areas, but some edits reliably crash the map service of ClemensElflein/open_mower_ros, even after deleting the map and restoring a json backup, the directly performing the edit.

I've stripped the Map* values to reduce PII, but these are my areas. When I try to combine area 4 with 7 it will always crash the ros map service: map_40_stripped.json

I hope this can aid in debugging that issue. Also still happens when I remove all navigation areas, and areas 0-3 manually before importing the json and performing the edit.

AndreKR commented 2 months ago

I think I'm running into the same problem.

My map simply contains two areas, one of them with one obstacle: map (5).json

When I try to merge the two areas, it breaks the mower.

One way to recover is to delete map.bag and import the map again. The import works (with the two separate areas), but if I try to merge the areas again, it will break the map service again.

AndreKR commented 2 months ago

I think the issue (or at least something that is rather strange) is that after the merge, the GUI still tries to save two areas, and the first one has no points.

image

I'm assuming the second one would actually contain the merged area, but since the first one already corrupts the map, the request for the second one fails as well.
Edit: Yes, I can confirm that if I take the points of the second request, make the necessary replacements ("x" -> "Package": 0, "X", "y" -> "Y", "z" -> "Z") and put it in the JSON as the only area, I can restore that JSON as a merged map.

karlranseierausrom commented 2 months ago

In my case it only happens if I combine the first map with another, if I investigated correctly. This fits to the observation of Andre.

juditech3D commented 1 month ago

hello, I confirm I have exactly the same problem as @AndreKR.