search

ceddlyburge / elm-league-tables-from-google-sheets

A website to show league tables and fixtures, from results stored in Google Sheets
https://se-polo-2019.netlify.com/
MIT License
8 stars 0 forks source link

Refactor aggregated scorers calculation #66

Closed ceddlyburge closed 4 years ago

ceddlyburge commented 4 years ago

Separate out the calculation of the aggregated scorers, which in turn leads to have a DecodedGame type (for the representation of the Game in the spreadsheet) and a Game type (to represent the game after calculations have happened on it)

codecov[bot] commented 4 years ago

Codecov Report

Merging #66 into master will increase coverage by 0.18%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #66      +/-   ##
=========================================
+ Coverage   82.11%   82.3%   +0.18%     
=========================================
  Files          37      39       +2     
  Lines        1454    1458       +4     
=========================================
+ Hits         1194    1200       +6     
+ Misses        260     258       -2
Impacted Files Coverage Δ
src/Calculations/PlayersFromLeagueGames.elm 100% <ø> (ø) :arrow_up:
src/Models/Game.elm 100% <ø> (ø) :arrow_up:
src/Calculations/LeagueTableFromLeagueGames.elm 95.51% <ø> (ø) :arrow_up:
src/Calculations/GameFromDecodedGame.elm 100% <100%> (ø)
src/Pages/ResultsFixtures/View.elm 100% <100%> (+0.75%) :arrow_up:
src/Models/DecodedGame.elm 100% <100%> (ø)
...rc/Calculations/ResultsFixturesFromLeagueGames.elm 100% <100%> (+3.12%) :arrow_up:
src/GoogleSheet/DecodeGoogleSheetToGameList.elm 100% <100%> (ø) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32d0d14...0977903. Read the comment docs.