Get the Nth Percentile on the graph

[cedlecomte]

From ced.leco...@gmail.com on February 19, 2012 09:46:11

i have make some test to obtain the Nth percentile on the graph.

It's a little dirty and just a POC. Say me if it can be a interesting feature, I will review the code to do a better solution.

--- ../../rtg2-0.9.1-1/src/rtgplot.c 2012-02-17 16:12:13.000000000 +0100 +++ rtgplot.c 2012-02-19 15:38:07.000000000 +0100 @@ -1,4 +1,5 @@ /**** + Program: $Id: rtgplot.c,v 1.61 2008/01/19 03:01:32 btoneill Exp $ Author: $Author: btoneill $ Date: $Date: 2008/01/19 03:01:32 $ @@ -144,6 +145,7 @@ float interfaceSpeed = 0.0; data_obj_list_t DOLptr; data_t dataPtr;

• data_t *tmpData;

  /* debug file pointer */ dfp = stderr; @@ -354,7 +356,16 @@ if (LOs[i]) { normalize(LOs[i]->DO_aggr->data, PO, LOs[i]->factor); LOs[i]->shade = colors->shade;

• plot_legend(&img, PO, LOs[i], offset);
• if ( LOs[i]->percentile > 0 )
• {
• tmpData = copyData(LOs[i]->DO_aggr->data);
• tmpData = sort_data(tmpData, FALSE, FALSE);
• dataPtr = return_Nth(tmpData, count_data(tmpData), LOs[i]->percentile);
• plot_legend(&img, PO, LOs[i], offset, dataPtr);
• plot_Nth(&img, PO, dataPtr, LOs[i]->shade);
• } else {
• plot_legend(&img, PO, LOs[i], offset, NULL);

•     }
    colors = colors->next;
    offset++;
  }

  @@ -373,14 +384,14 @@ }

  /* Plot percentile lines if requested */

• for (i=0;i<=count.LOs;i++) {
• if (LOs[i] && LOs[i]->percentile > 0) {
• /* sort the newly created data_t list for the LO here */
• LOs[i]->DO_aggr->data = sort_data(LOs[i]->DO_aggr->data, FALSE, FALSE);
• dataPtr = return_Nth(LOs[i]->DO_aggr->data, count_data(LOs[i]->DO_aggr->data), LOs[i]->percentile);
• plot_Nth(&img, PO, dataPtr, LOs[i]->shade);
• }
• }
• //for (i=0;i<=count.LOs;i++) {
• // if (LOs[i] && LOs[i]->percentile > 0) {
• // /* sort the newly created data_t list for the LO here */
• // LOs[i]->DO_aggr->data = sort_data(LOs[i]->DO_aggr->data, FALSE, FALSE);
• // dataPtr = return_Nth(LOs[i]->DO_aggr->data, count_data(LOs[i]->DO_aggr->data), LOs[i]->percentile);
• // plot_Nth(&img, PO, dataPtr, LOs[i]->shade);
• // }

• //}

  if (HTMLOUT) { @@ -751,11 +762,12 @@ }

-void plot_legend(gdImagePtr img, plot_obj_t graph, line_obj_t LO, int offset) { +void plot_legend(gdImagePtr img, plot_obj_t graph, line_obj_t LO, int offset, data_t *nth) { char total[BUFSIZE]; char max[BUFSIZE]; char avg[BUFSIZE]; char cur[BUFSIZE];

• char perc[BUFSIZE]; char string[BUFSIZE]; char interface[BUFSIZE]; char *cp; @@ -799,6 +811,17 @@ snprintf(string, sizeof(string), "%s Total: %lld Max: %02.1f", interface, rate->total, (float)rate->max); } else {
• if ( LO->percentile > 0 )
• {
• snprintf(string, sizeof(string), "%s Max: %7s%s Avg: %7s%s Cur: %7s%s %huth: %7s%s [%7s]",
• interface,
• units(rate->max, max), graph->units,
• units(rate->avg, avg), graph->units,
• units(rate->cur, cur), graph->units,
• LO->percentile, units(nth->rate*8, perc), graph->units,
• units((float)rate->total, total));
• }
• else snprintf(string, sizeof(string), "%s Max: %7s%s Avg: %7s%s Cur: %7s%s [%7s]", interface, units(rate->max, max), graph->units, @@ -1917,3 +1940,16 @@ (rate->cur)*=factor; }

+data_t copyData(data_t src) {

• data_t *dest;
• if ( src == NULL )
• return NULL;
• dest = malloc(sizeof(data_t));
• dest->counter = src->counter;
• dest->timestamp = src->timestamp;
• dest->rate = src->rate;
• dest->x = src->x;
• dest->y = src->y;
• dest->next = copyData(src->next);
• return dest; +}

--- ../../rtg2-0.9.1-1/src/rtgplot.h 2012-02-17 16:12:13.000000000 +0100 +++ rtgplot.h 2012-02-19 15:22:00.000000000 +0100 @@ -38,7 +38,7 @@

define DEFAULT_UNITS "bps"

define NUM_LINE_COLORS 10

-#define LEGEND_MAX_LEN 17 +#define LEGEND_MAX_LEN 10

define COPYRIGHT "RTG"

define DEBUGLOG "/tmp/rtgplot.log"

@@ -169,7 +169,7 @@ void writegraph(gdImagePtr , char ); void plot_scale(gdImagePtr , plot_obj_t ); void plot_labels(gdImagePtr , plot_obj_t ); -void plot_legend(gdImagePtr , plot_obj_t , line_obj_t , int); +void plot_legend(gdImagePtr , plot_obj_t , line_obj_t , int, data_t ); void init_colors(gdImagePtr , color_t _); void calculate_rate(datat *, rate_t ); void calculate_total(data_t _, rate_t ); @@ -200,6 +200,7 @@ int copyDO(data_obj_t , data_obj_t ); void clearEmpties(); void rateFactor(rate_t , int); +data_t copyData(data_t );

/* Precasts: rtgparse.c _/ char getField(char c, char sep, char *_result);

Attachment: rtgplot.cgi.png

Original issue: http://code.google.com/p/rtg2/issues/detail?id=29

[bewing]

It looks like this moves the percentile line plot to the legend plotter, and modifies the legend plot to include the numerical information. I like it.