cedlemo / blingbling

Awesome WM widgets
GNU General Public License v2.0
148 stars 37 forks source link

Added working system.lua #15

Closed quizzmaster closed 11 years ago

quizzmaster commented 11 years ago

I don't really know if and what i changed, but the shutdown and reboot widgets are working with awesome 3.5 perfectly

cedlemo commented 11 years ago

Hi quizzmaster,

Thanks for this you help me a lot . I think that you have forgotten to add the init.lua in your pull request. Can you do antoher pull with the two file after I have closed this one ?. Further more if it 's something that interest you ( it 's not mandatory I can do this later) could you transform the module declaration into the standard way for lua 5.2 (even if the older way is still working), look:

the initial file:

module("blingbling.system") 

function shutdownmenu(button_image, accept_image, cancel_image) 
--code
end

function rebootmenu(an_image, accept_image, cancel_image)
--code
end

new module definition :


local function shutdownmenu(button_image, accept_image, cancel_image) 
--code
end

local function rebootmenu(an_image, accept_image, cancel_image)
--code
end

return {
  shutdownmenu = shutdownmenu;
  rebootmenu = rebootmenu
}

I think that I will add a field "Contributors" in the README.md . Can I add your name in it for this?

Waiting for answer from you before closing this .

Thanks again

quizzmaster commented 11 years ago

Just transformed the module declaration and added the system module to init.lua.

Yes, you can add me in the Contributors list.

No problem for doing this, i just adapted your old file.

quizzmaster commented 11 years ago

I didn't read the code carefully enough ;)