cedricbahirwe / dialer-android

The Android Version The Dialer App using Kotlin
https://cedricbahirwe.com/html/dialit
MIT License
5 stars 1 forks source link

Adding Splash/Launch Screen #37

Closed cedricbahirwe closed 11 months ago

cedricbahirwe commented 11 months ago

Building Splash/Launch Screen of the app using the right technologies (not hacky, less friction, easy to maintain)

Resources:

  1. By @esthcarelle : https://github.com/cedricbahirwe/dialer-android/issues/37#issuecomment-1747190241

Assets: App + Company Icons

iPhone 15
esthcarelle commented 11 months ago

@cedricbahirwe are you using the splash screen library?

esthcarelle commented 11 months ago

and what do you mean with less friction? I can only see an image, could you add a video?

cedricbahirwe commented 11 months ago

@cedricbahirwe are you using the splash screen library?

No, I meant a launch screen, (just icons, no animations whatsoever )

cedricbahirwe commented 11 months ago

and what do you mean with less friction? I can only see an image, could you add a video?

I meant, a way to have the launch screen without hacking our way in

esthcarelle commented 11 months ago

The launch screen is the splash screen right?

esthcarelle commented 11 months ago

I do not understand your point can you send me a professional voice note on whatsapp? Regards

esthcarelle commented 11 months ago

Are you using the splash screen library or are you creating the splash screen yourself?

cedricbahirwe commented 11 months ago

I’m planning to create the splash myself…

On Wed, Oct 4, 2023 at 2:29 PM Esther Carrelle @.***> wrote:

and what do you mean with less friction? I can only see an image, could you add a video?

— Reply to this email directly, view it on GitHub https://github.com/cedricbahirwe/dialer-android/issues/37#issuecomment-1746778503, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALWEKFXFV72YRLRE7FNUUZDX5VJDLAVCNFSM6AAAAAA5PC7K5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBWG43TQNJQGM . You are receiving this because you were mentioned.Message ID: @.***>

esthcarelle commented 11 months ago

this can also work right https://developer.android.com/develop/ui/views/launch/splash-screen?

esthcarelle commented 11 months ago

I can work on it if u don't mind?

cedricbahirwe commented 11 months ago

Yes, please go ahead. That would be great

On Wed, Oct 4, 2023 at 5:52 PM Esther Carrelle @.***> wrote:

I can work on it if u don't mind?

— Reply to this email directly, view it on GitHub https://github.com/cedricbahirwe/dialer-android/issues/37#issuecomment-1747192251, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALWEKFRNKRAC47CABANJE2LX5WA3VAVCNFSM6AAAAAA5PC7K5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGE4TEMRVGE . You are receiving this because you were mentioned.Message ID: @.***>

cedricbahirwe commented 11 months ago

Yes, I that’s exactly what I meant by friction less (native way) Thanks .

On Wed, Oct 4, 2023 at 6:01 PM Esther Carrelle @.***> wrote:

this can also work right https://developer.android.com/develop/ui/views/launch/splash-screen?

— Reply to this email directly, view it on GitHub https://github.com/cedricbahirwe/dialer-android/issues/37#issuecomment-1747190241, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALWEKFVIPGIQHQJ3DP4FVZLX5WB5HAVCNFSM6AAAAAA5PC7K5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGE4TAMRUGE . You are receiving this because you were mentioned.Message ID: @.***>

esthcarelle commented 11 months ago

@cedricbahirwe could you please add a red png icon in the folder you provided or an SVG icon?

cedricbahirwe commented 11 months ago

@cedricbahirwe could you please add a red png icon in the folder you provided or an SVG icon?

@esthcarelle , I have updated the archive with the red icon, please not that I could not make an SVG

esthcarelle commented 11 months ago

@cedricbahirwe as you can see with this attached screenshot the branding name has to be an image yet for us we have the abc logo + "powered by" text so with the solution we decided to go with there are 2 possible solutions: 1.If we decide to keep using the splash api which is the much faster way both on implementation side and performance, You might combine the text and the abc logo into one image(png)

  1. We decide to go the old way(we create the splash activity and we build the screen ourselves Screenshot from 2023-10-06 10-21-02
cedricbahirwe commented 11 months ago

Would providing "powered by + logo" as a PNG work ?? If so, then we'd have to go with red option because black would not work in dark mode!?

Red Black
esthcarelle commented 11 months ago

Thanks

esthcarelle commented 11 months ago

Aspect ratio of the branding image should be 5:2. For example, if the width is 200, then the height should be 80(200/2,5).The one you provided looks squizzed device-2023-10-06-124255.webm

esthcarelle commented 11 months ago

And for the icon Icon needs to be square(aspect ratio — 1:1). Visible part of the icon will be only /1.5.

cedricbahirwe commented 11 months ago

which dimension do you need for the brand? (Width + height)

cedricbahirwe commented 11 months ago

By the way, I'm using https://www.remove.bg/ to remove background once I crop the screenshot I shared

esthcarelle commented 11 months ago

@cedricbahirwe 200dp width and 80dp height

cedricbahirwe commented 11 months ago

Try this and let me know, please, then I can provide the red colour version

200x80-removebg-preview

cedricbahirwe commented 11 months ago

The app icon is sqaured( 350x350), what is missing?

cedricbahirwe commented 11 months ago

@esthcarelle Try this one, it's 400x400 with the icon smaller If possible, let me know the exact dimensions and I can make it work

Example: