Closed cedricbonhomme closed 9 years ago
cedricbonhomme
commented
9 years ago Indeed, it is slow with my 74 feeds (especially on Heroku). And its one of my main concerns. It was a little faster before the addition of the sidebar, which displays the number of unread articles per feeds...
The /unread page offers good performances. So it has become my "main page".
Original comment by: Cédric Bonhomme
cedricbonhomme
commented
9 years ago I don't really know if it's possible to keep the view with 9 tiles per feed and still get this page quickly. If you don't mind I was thinking about redoing the page : a simple html table with a javascript datagrid would be easier to read.
Original comment by: François Schmidts
cedricbonhomme
commented
9 years ago Why not. But how a JS datagrid will solve the problem? Maybe by using a REST API (at least the GET method) to load the table in async?
Original comment by: Cédric Bonhomme
cedricbonhomme
commented
9 years ago I already tried Flask-RESTful, quite easy to use.
Original comment by: Cédric Bonhomme
cedricbonhomme
commented
9 years ago Sorry this wasn't really what I meant. I actually implemented what I had in mind in PR #3. I didn't have much time so no async, no ajax, not even a bit of javascript. It's a first draft but I think it's an improvement. Waiting on you review.
Original comment by: François Schmidts
cedricbonhomme
commented
9 years ago It works perfectly and I like the result! I think that it is a great improvement. I will look at it deeper tonight, thanks for the work!
Original comment by: Cédric Bonhomme
cedricbonhomme
commented
9 years ago The new version of the home page takes no time to load. So the issue might be considered closed.
Original comment by: François Schmidts
cedricbonhomme
commented
9 years ago That's fine! I am currently looking at the code. There is a strange bug with the menu, only on Heroku!
I am investigating...
Original comment by: Cédric Bonhomme
cedricbonhomme
commented
9 years ago I found the problem. On my local installation there is only one account in pyAggr3g470r (so no problem), but there are more accounts on Heroku. And in fact, the numbers of unread articles in the CSS badges are coming from feeds from the other users. It is now fixed by 6eb4f8a.
Original comment by: Cédric Bonhomme
cedricbonhomme
commented
9 years ago Ah. Yeah. That's a dumb mistake I made there ! Thanks for the review !
Original comment by: François Schmidts
The homepage actually makes one request per feed which can be quite long with many feeds. There's surely some way to improve that.