supporting updated - Githubissues

jaesivsm commented 8 years ago

crawler should be able to edit an article that has been updated, a notification in the ui should also be made available if the user opted in or did not opt out (tbd)

cedricbonhomme commented 8 years ago

I can update the crawler which is using asyncio. Not a problem. In fact it was a choice not to update the content of articles. But today I agree with you.

For the notification in the UI, the first thing to do is to mark again the article as unread. Maybe also add a Boolean (for example "is_updated") in the Article model, that will be used if the user opted in (or always...). But, I don't think that it is necessary to highlight the changes (kind of diff).

jaesivsm commented 8 years ago

For the notification in the UI, the first thing to do is to mark again the article as unread. It may be interesting to suggest that the article has been updated and isn't new in the UI and not just "unread" it. Also, it may not be useful to unread a message which neither the content or the title has been updated. Even so, do I want to re-read an article just because the title has changed ? I'm not sure.

All of that could be customizable of course but I don't think it's the way to go. So here are the specs as I see them :

never update anything but title and content
if the article is still unread, modify the article without notifying
if the article is read but the content is not modified by an update, modify the title but do not notify it to the user
if the article is read and the content is modified by an update, modify the db article, mark as unread, place a marker "updated" ( bool, like "read" ), mark both "read" and "updated" as false when read

That the fairest I could come up with.

cedricbonhomme commented 8 years ago

I think we need an option in order to disable this.

After only one day of use, I realize that a non-negligible number of articles are regularly updated. Generally articles from news feeds, but not only. Or for example just now, this article: https://www.laquadrature.net/en/Net-Neutrality-Major-Setback-for-Internet This is annoying.

Or maybe it is just badly implemented... But some feeds do not have this problem.

I'll try to look more precisely where is the problem (encoding problem, a variable part in a feed with JavaScript?, etc.).

cedricbonhomme commented 8 years ago

I'll also test if the entry has been updated (https://pythonhosted.org/feedparser/reference-entry-updated.html).

cedricbonhomme / newspipe

supporting updated #27