cedricboon / openhab-addons

Add-ons for openHAB 2.x
Eclipse Public License 2.0
6 stars 5 forks source link

Change in structure for New Things with latest binding #22

Closed MDAR closed 4 years ago

MDAR commented 4 years ago

Hi

I've fixed a few other things so can now try your latest binding.

Which seems to be working well.

But I've noticed something that may be an issue.

Previously, Thing ID's contained the Hex address

as in

velbus:vmbgp1:abcdefg:0F

but now, they don't have the HEX address included.,

I'm yet to try... but what happens if there are two of a the same module type?

How would it define the two as different?

MDAR commented 4 years ago

I think this might be part of a bigger problem with a machine I have.

I've started with a totally fresh Odroid C2, with DietPi Stretch (Due to Java 1.8 issue).

Using this binding version is working just fine.

MDAR commented 4 years ago

I'm not sure this is or is not an issue.

I've just added a VMBGPOD-2 to a setup and the resulting ID seems to be missing the HEX address, as shown here when compared to the VMBPIRM that was added with a previous binding (some months ago)

2020-03-19 14:06:12.093 [me.event.ThingUpdatedEvent] - Thing 'velbus:vmbgpod-2:da17c063' has been updated.
2020-03-19 14:06:30.672 [vent.ChannelTriggeredEvent] - velbus:vmbpirm:bee8405f:01:input#CH3 triggered PRESSED
2020-03-19 14:06:31.068 [vent.ChannelTriggeredEvent] - velbus:vmbpirm:bee8405f:01:input#CH3 triggered RELEASED
MDAR commented 4 years ago

No that'll be my fault again.

But an interesting observation.

I entered the wrong base address when I added the module originally and blindly copied the information this time into another manually created Thing, as it didn't appear in the Inbox with the address I expected.

So by adding it via the inbox, with the correct Base Address, the whole Thing is created exactly as expected.

2020-03-19 14:14:52.897 [me.event.ThingUpdatedEvent] - Thing 'velbus:vmbgpod-2:bee8405f:54' has been updated.
2020-03-19 14:14:52.927 [me.event.ThingUpdatedEvent] - Thing 'velbus:vmbgpod-2:bee8405f:54' has been updated.
2020-03-19 14:14:53.112 [me.event.ThingUpdatedEvent] - Thing 'velbus:vmbgpod-2:bee8405f:54' has been updated.
2020-03-19 14:15:16.644 [vent.ChannelTriggeredEvent] - velbus:vmb8pbu:bee8405f:3D:input#CH1 triggered RELEASED