search

cedricdelpoux / react-responsive-masonry

React responsive masonry component built with css flexbox
https://cedricdelpoux.github.io/react-responsive-masonry/
MIT License
381 stars 37 forks source link

ResponsiveMasonry #128

Open SarkorbekA opened 3 months ago

SarkorbekA commented 3 months ago

image i can't understand, what is the problem? image

chintanw3nuts commented 3 months ago

Same here

rusith commented 3 months ago

image

This happens because using defineProperty with only a getter makes it immutable. I think this is an issue with the build system.

I tried to build the code using v21.7.1 and it produces a different output. I am not sure which version the code authors used.

rusith commented 3 months ago

I had to build it myself using the latest node version. hope this gets fixed soon (build using a latest node version import from the lib folder)

MNITD commented 2 months ago

My team had this issue after regenerating the package-lock.json file during updating unrelated dependency

Our workaround is to downgrade to v2.2.0 and make it strict in package.json

terminal:

npm i react-responsive-masonry@2.2.0

package.json:

- "react-responsive-masonry": "^2.2.0",
+ "react-responsive-masonry": "2.2.0",
AndreyMarchuk commented 1 month ago

same issue, v2.2.1 works without issues

ADTC commented 3 days ago

Regardless of the above, I wonder why a ResponsiveMasonry wrapper component is necessary when the Masonry component itself could be coded to accept a breakpoint object or breakpoint array instead of a number for columnCount (or as another prop) and simply make itself responsive based on it. 😆