search

cedrickring / golang-action

A GitHub Action to run Go commands
Apache License 2.0
134 stars 33 forks source link

Closes #8 Fixes action test failure for go dep with vendored dependencies #10

Closed dougnukem closed 5 years ago

dougnukem commented 5 years ago

Closes #8, Closes #2 - fixes github action run failure on the test case of a go project with dep vendored dependencies.

Now instead of just running dep check we will run dep ensure && dep check and check that nothing in the git workspace is modified/untracked e.g. Gopkg.toml/Gopkg.lock which would indicate there are changes to dependencies that were not explicitly committed.

dougnukem commented 5 years ago

Out of curiosity do Github actions not run on forked pull-requests? Maybe the forked repo also needs github actions enabled.

cedrickring commented 5 years ago

Maybe you need Github Actions too. Though I could create an action which triggers a build when I create comment on a PR (for those who doesn't have Github Actions enabled). Like this.