search

cedrickring / golang-action

A GitHub Action to run Go commands
Apache License 2.0
134 stars 33 forks source link

Go dep vendored tests are failing #15

Closed cedrickring closed 5 years ago

cedrickring commented 5 years ago

For some reason after this commit, the tests are failing again: https://github.com/cedrickring/golang-action/commit/f03f0f8b720ae8c7ae0f2dd49679adb48dbc0833

Run: https://github.com/cedrickring/golang-action/runs/79343982

@dougnukem some ideas?

cedrickring commented 5 years ago

I guess the problem is that the files, for some reason, are being shared between the action containers (?) and changes from other test checks are also reflected in go dep vendored check...

Found out while messing around with the action in a docker container trying to reproduce that git difference. Otherwise I don't know how the go_standard folder could be modified...

dougnukem commented 5 years ago

@cedrickring that makes sense, i forgot it re-uses the same workspace. I'll make a fix for that.

dougnukem commented 5 years ago

@cedrickring there's a fix to .gitignore the built binary output which was causing git status to report workspace changes when its just a binary build that isn't meant to be part of the repo