Closed dougnukem closed 5 years ago
@dougnukem you need to rebase now
So to bump the version, I just have to call version-bump-<major|minor|patch>
right?
I like that approach. Makes updating the action quite easy while still having support for all go versions! 😄
@cedrickring rebased
Yes for releases you should be able to just run:
$ make version-bump-minor
$ git commit -a -m "update minor version"
# Do a github release
We could even look into doing a more robust one:
# runs bump-version-<major | minor | patch>
# commits changes
# Tags build and creates a github release and tag with $VERSION
$ make release-version-minor
depends on https://github.com/cedrickring/golang-action/pull/3
Manages support for multiple golang versions in the repo so they can be referenced by github repo URL in ,
Dockerfile
as the templatego1.10
go1.11
go1.12
The benefit of having these in the repo itself it means that users that want to import that action can do it by github URL and don't have to rely on adding / maintaining special
go1.10/go1.11/go1.12
branches and tags. This is similar to how Golang manages multiple versions of go in their official Docker images:For example now to use a specific version of go users can reference it as:
This PR also updates the Docker tag and publish behavior.
See here for examples of tagged images published to Docker hub:
Docker images are published and tagged as follows:
LABEL version="1.2.3"
indicatesMAJOR.MINOR.PATCH
semantic versionDockerfile
golang-action:1.2.3
- for users that want to pin it to the exact versiongolang-action:1.2
- for users that want to pin it to a specificminor
versiongolang-action:1
- for users that want to pin it to a specificmajor
versionWe then build and publish specific go version variants for users that want to pin the specific go version they are using:
golang-action:1.2.3-go1.10
golang-action:1.2-go1.10
golang-action:1-go1.10
golang-action:1.2.3-go1.11
golang-action:1.2.3-go1.12
Next Steps
master
at least thepatch
version should be bumped (we could do that automatically as part of the@master
Actions workflow, not sure thats right though, maybe it can check if a git tag for the currentLABEL version="1.2.3"
exists and if it does increment the patch version, commit that and build and tag it