search

cedricongjh / pe

0 stars 0 forks source link

Cannot have decimals points for comission #6

Open cedricongjh opened 3 years ago

cedricongjh commented 3 years ago

image.png

When trying to edit a policy to have 20.5% commission, it states that it must be a number. 20.5 is a reasonable commission percentage, and also a number. This is not mentioned in the user guide as well:

image.png

Since commissions might have decimal points, this is detrimental to the user for those who need to record commissions with decimal points. It is expected that decimal points are accepted.

nus-pe-bot commented 3 years ago

Team's Response

Based on our research, commission rates are integer values.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: I do not agree that commission rates are only integer values.

image.png

source: https://dollarsandsense.sg/much-commissions-insurance-agents-earn/

image.png

source: https://blog.moneysmart.sg/life-insurance/ever-wondered-how-insurance-agents-in-singapore-make-money-from-your-policies/

It is clear that commission rates can be non-integer values, and I would argue that many target users of the application would be affected by this, as they might have non-integer commission rates. Moreover, the fact that only integer commission rates are supported is not clear, until they actually try the application. On page 6 of the UG:

image.png

It does not state the restrictions that commission rate can only be integers as well. It would be something that the user discovers on their own using the application, and this would hinder many users especially those insurance agents with non-integer commission rates.