cedrozor / myrtille

A native HTML4 / HTML5 Remote Desktop Protocol and SSH client
https://www.myrtille.io
Apache License 2.0
1.78k stars 372 forks source link

Utility GetHash.aspx could result in plaintext logging of password on server #364

Open jbtule opened 1 year ago

jbtule commented 1 year ago

From the docs

From version 2.3.0, you can also generate a password hash from url (thanks jol64). syntax: https://server/myrtille/GetHash.aspx?password=password

I went to check the source to see if there was a possible alternate usage of that handler using a post and Request.Form but there isn't. https://github.com/cedrozor/myrtille/blob/b99671589ad0c18f7ccb0878d08e05bcb9cb15c6/Myrtille.Web/GetHash.aspx.cs#L44

Query strings are often logged on webservers, not something you want to happen with a clear text password. I suggest at least having alternate post version and recommending it, if not replacing it outright for poor practice.

deezed420 commented 1 year ago

Not a bad idea.

deezed420 commented 1 year ago

I think you should put a pull request for it