search

cedvdb / flutter_circle_flags

Circular flags for flutter
https://pub.dev/packages/circle_flags
MIT License
11 stars 22 forks source link

Fix for web html renderer #11

Closed blopker closed 1 year ago

blopker commented 1 year ago

After some experimentation, I saw that the images weren't working even before the flutter_svg 2 update. It turns out some SVGs had a circle mask on them, even though the Flutter code also applied a mask. I've removed the SVG mask and now the images show up in the example project using the HTML renderer (flutter run -d chrome --web-renderer html). Also tested on canvaskit web and Android.

cedvdb commented 1 year ago

Great find, thanks !

blopker commented 1 year ago

@cedvdb, nudge for a release :)

cedvdb commented 1 year ago

available on version 1.0.4, I fixed the other bug with the parser and will release another version of the phone form field soon

blopker commented 1 year ago

Awesome! Thank you :)

cedvdb commented 1 year ago

@blopker Can you share the script that you used to remove the mask ?

blopker commented 1 year ago

Hey! It's been a while, but I would have probably used VSCode's bulk find and replace feature for this. I don't specifically mention using a script in the original comment, so that's my guess. I'll let you know if I find a script though.