search

cedvdb / flutter_circle_flags

Circular flags for flutter
https://pub.dev/packages/circle_flags
MIT License
11 stars 22 forks source link

Use optimized vector format #22

Closed xvrh closed 1 year ago

cedvdb commented 1 year ago

I'm reverting this as there didn't seem that there was any benefit (on the web) when images are preloaded.

If you require this or want to compare here is the compiled svg branch and here is the normal one

Both using a preloading mechanism. I did not find any difference (manual testing) so I'll merge the one that does not use precompiled picture.

xvrh commented 1 year ago

I'm fine with a revert.

cedvdb commented 1 year ago

Do you recall how were those images generated ? Looking at them right now I see those are square images while the original are circles.

xvrh commented 1 year ago

@cedvdb The optimised .vec files are generated by running dart tool/compile_svgs.dart.

I see those are square images while the original are circles.

What do you mean exactly? I see the .svg are square. And they both (.svg & .vec) render as circle because of the ClipOval widget.

cedvdb commented 1 year ago

Thanks ! tool wasn't part of main for some reason and it's been a long time.

What do you mean exactly?

The repository from which the svg are taken has circle flags. I was wondering if the fact that svgs are now squared flags is due to the optimization process that shows information that was hidden or if you changed those files yourself.

image

xvrh commented 1 year ago

tool wasn't part of main for some reason and it's been a long time.

This PR was reverted entirely with this commit: https://github.com/cedvdb/flutter_circle_flags/commit/15f3a574e937f5f2fcdeb0cb027695a8c2a6331c

The repository from which the svg are taken has circle flags

The flags seems to have turned square with this previous PR: https://github.com/cedvdb/flutter_circle_flags/pull/11