search

cedvdb / flutter_circle_flags

Circular flags for flutter
https://pub.dev/packages/circle_flags
MIT License
10 stars 21 forks source link

Flags do not appear in mobile web browser #9

Open esmlima opened 1 year ago

esmlima commented 1 year ago

I don't understand why, but I'm facing different behaviour in flutter web projects when accessed from Desktop vs Mobile.

My demo project: https://payment.gula.mobi/#/

On desktop it works fine: image

On Android mobile, using Chrome: Mobile Chrome

On Android mobile, using Firefox: Mobile Firefox

On iPhone, using Safari: iPhone Safari

cedvdb commented 1 year ago

Good catch, hopefully someone can look into it. It might be due to svgs.

arjittw commented 1 year ago

Actually, they are not working in html renderer, only working in CanvasKit renderer. By default, flutter uses CanvasKit on desktop browsers and html renderer on mobile browsers.

cedvdb commented 1 year ago

This might be due to the move to flutter-svg, as I recall it was working previously

blopker commented 1 year ago

Related: https://github.com/dnfield/flutter_svg/issues/845

Yeah, looks like it's an issue with flutter_svg.

blopker commented 1 year ago

Made a PR, hope it helps: https://github.com/cedvdb/flutter_circle_flags/pull/11

cedvdb commented 1 year ago

Thanks a lot @blopker I'll get on it this weekend, I'm drowning in high priority tasks right now

cedvdb commented 1 year ago

should be fixed in 1.0.4

agordeev commented 5 months ago

This issue happens again in 5.0.0

cedvdb commented 5 months ago

the flags were regenerated with the original library https://github.com/HatScripts/circle-flags which readded the mask.

cyrilmata commented 4 months ago

Hello, this issue happens again in 5.0.0, flutter_svg causes error in web release mode only image

I rollback to previous version waiting for a fix :)

cedvdb commented 4 months ago

@cyrilmata the original fix is linked above and can be reimplemented. Since the process has to be repeated each time the flags are regenerated, this should be implemented in a way that fixes the issues every time the files are regenerated.

This issue in the original repository would fix it at the source: https://github.com/HatScripts/circle-flags/issues/105