search

cedvdb / phone_form_field

Flutter phone number input
https://pub.dev/packages/phone_form_field
MIT License
73 stars 100 forks source link

document enhancement about override flags #222

Closed yousefak007 closed 8 months ago

yousefak007 commented 9 months ago

hi, thank you for doing this library

I see some people complain about some inaccurate flags, and this library depends on circle_flags lib, and it needs to change or update flags on that library first

for example, Saudi and Iraq flags are inaccurate

for an easy solution and rather than waiting, I can override that package assets by doing this:

I just made packages/circle_flags/assets/svg/ folder:

image

then in pubspec.yaml I added in assets:

  assets:
    - packages/circle_flags/assets/svg/

image

it will be helpful if this information is added to the documentation of this library

cedvdb commented 9 months ago

Good idea

The original flags are there: https://github.com/HatScripts/circle-flags and should be changed there when change are needed.

For the documentation it should be added here:

https://github.com/cedvdb/flutter_country_selector

Lionapi commented 7 months ago

Hello,

i tried to use the version 9.2.3 of Phone_form_Field and i got this error : see the attached picture. error_flutter

can you help me please ?

cedvdb commented 7 months ago

@Lionapi What does that have to do with flags ? Change to ...PhoneFieldLocalization.delegates (add ... in front, since it's an iterable).

Lionapi commented 7 months ago

@cedvdb I know there's no connection between the two, but after looking for a way to contact you, here's the one I found. However, even adding it in front as you say, the same error persists and i'm still stuck.

cedvdb commented 7 months ago

Please create your own issue, with a code snippet using the ... as I suggested above. Also post the error message you are having after using ...