cedvdb / phone_form_field

Flutter phone number input
https://pub.dev/packages/phone_form_field
MIT License
72 stars 100 forks source link

Add Hungarian localization messages #226

Closed emri99 closed 8 months ago

emri99 commented 8 months ago

Content

Notice

Changes on existing generated files seems useless & only related to formatter.

I've used flutter 3.19.3 and command flutter gen-l10n.

cedvdb commented 8 months ago

Thanks, You can just run dart fix --apply to fix the generated files

emri99 commented 8 months ago

Changes remains about line length like here, do I need to do anything else ?

I was thinking about push force to cancel the modifications I've made so they'll never appear in history, is that ok for you ?

cedvdb commented 8 months ago

I don't know what's up with those line length, it seems to change in every other PR and I let it pass. So honnestly just push it with dart fix --apply and with the line length changes.

emri99 commented 8 months ago

Generated files updated & push-forced. Let me know if anything else should be changed ;)

Sorry (misclick on Comment & Close !)

emri99 commented 8 months ago

Sorry to bother you, do you have planned to release a version including this update ?

Thanks again for your hard work

cedvdb commented 8 months ago

It's going to be in the upcoming days, I would like to ship other fixes as well

emri99 commented 8 months ago

Perfect ! Thanks for the info ;)

cedvdb commented 8 months ago

Not sure why you did not add all hu message but I'm adding the remaining ones via google translate since i'm doing it for each missing translation:

  "selectACountrySemanticLabel": "Válasszon országot, jelenlegi választás: {countryName} {dialCode}",
  "@selectACountrySemanticLabel": {
    "description": "semantic description of the country button",
    "placeholders": {
      "countryName": {
        "type": "String"
      },
      "dialCode": {
        "type": "String"
      }
    }
  },
  "phoneNumber": "Telefonszám",
  "currentValueSemanticLabel": "Jelenlegi érték: {currentValue}",
  "@currentValueSemanticLabel": {
    "description": "semantic description of the phone input. The label or hint will be dynamically added",
    "placeholders": {
      "currentValue": {
        "type": "String"
      }
    }
  }
emri99 commented 8 months ago

Hmm... Neither do I ! Sorry for that !

cedvdb commented 8 months ago

No problem, I've added language selection to the demo if you want to check the hungarian language https://cedvdb.github.io/phone_form_field/

emri99 commented 8 months ago

Check done ! No problem found ;)