cedvdb / phone_numbers_parser

Dart phone number parser, based on libphonenumber and PhoneNumberKit.
https://pub.dev/packages/phone_numbers_parser
MIT License
63 stars 32 forks source link

Add support for VOIP numbers #59

Closed letsar closed 8 months ago

letsar commented 8 months ago

This PR adds support for VOIP phone numbers. Should fix #48

cedvdb commented 8 months ago

Great ! Could you make two separate PR for the metadata upgrade and the voip feature ? Stuff like leading digits changes seem to come with the PR and are probably just metadata upgrades that don't necessarily require much scrutiny. It would be easier for review

Also please:

letsar commented 8 months ago

Ok, I'll revert my changes for the metadata and keep here only the support for the voip feature. Since we add a new feature wouldn't it be better to bump to the next minor version: 8.2.0?