search

cedws / discord-delete

Tool to delete Discord message history
GNU General Public License v3.0
126 stars 18 forks source link

Change channel skipping algorithm to avoid using &channel_id #29

Closed cedws closed 3 years ago

cedws commented 3 years ago

Hey @git-bruh, apologies, your original skipping algorithm was actually perfectly fine. This pull request takes some inspiration from there to avoid the problem mentioned in #27.

I also changed the parameter usage so that you pass it multiple times to skip multiple channels. Like so: -s 1234... -s 1234...

This will need a bit of docs in the wiki before a release can be made so nobody misuses the feature.

git-bruh commented 3 years ago

I've written a small wiki page here

cedws commented 3 years ago

Oh nice, thanks for writing this! I think you should be able to edit the wiki on this repo now (if not let me know). Also, I just made a change so that skipping whole guilds works again.

git-bruh commented 3 years ago

No, still didn't get write access:

ERROR: Permission to adversarialtools/discord-delete.wiki.git denied to git-bruh.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
cedws commented 3 years ago

Should work now...

git-bruh commented 3 years ago

Thanks, I've made the page but for some reason git from cli wasnt able to push here so i couldn't add images, had to use the github web interface. So the images will have to be added you (from my wiki repo).

cedws commented 3 years ago

Ah thanks, apparently to be able to push to the wiki repo, write access is needed to the main repo as well. Inconsistent with the UI.

I've pushed the images, thanks again for writing that.