search

cee-chen / object-fit-polyfill

A Javascript polyfill for browsers that don't support the object-fit CSS property.
ISC License
496 stars 93 forks source link

Upload non-minified version to npm #59

Closed ajlende closed 3 years ago

ajlende commented 3 years ago

I found this polyfill when working on WordPress/gutenberg. However, plugins must include a (mostly) human readable version of the code. Uploading the src folder to npm would allow us to use it.

cee-chen commented 3 years ago

Ahhh I hadn't realized, thanks so much! Here I was thinking I was trying to save some bytes 🤦‍♀️ The security concern totally makes sense though. Thanks!

cee-chen commented 3 years ago

Also privately I am TOTALLY over the moon that my small polyfill will be used by WordPress 😄 To be honest I wasn't really sure it'd be of huge use after Edge switched to webkit. Super cool, and definitely reach out if y'all need any further updates and I should get off my butt!

noisysocks commented 3 years ago

Thanks for merging this @constancecchen! Could you please publish a new release to npm so that when I npm install objectFitPolyfill I get the src folder in my node_modules?

cee-chen commented 3 years ago

Ah yes, apologies!! 🤦‍♀️ I should have just done so here, please let me know if you have any issues with the published package. Also don't hesitate to keep prodding me about things like this!

noisysocks commented 3 years ago

Thank you! Shall do 🙂