search

ceeK / Solar

A Swift micro library for generating Sunrise and Sunset times.
MIT License
568 stars 82 forks source link

Xcode 12.5 Build Warning #54

Closed sepw closed 3 years ago

sepw commented 3 years ago

I get the following build warning when building with Xcode 12.5:

/Users/me/Library/Developer/Xcode/DerivedData/Project/SourcePackages/checkouts/Solar/Package.swift The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.5.99.

This appears to have been fixed for Solar.podspec by 07e6310. Solar's Package.swift was likely overlooked. Please update the Package.swift deployment target to be consistent with the Solar.podspec.

1ec5 commented 3 years ago

Yes, it looks like #53 only touched the CocoaPods podspec and Xcode project (for Carthage-based builds).

/cc @MaximAlien

MaximAlien commented 3 years ago

Sorry, looks like I've missed that. Created PR which fixes this in https://github.com/ceeK/Solar/pull/55.

sepw commented 3 years ago

That's great! Thank you for fixing this issue so quickly.