search

ceedee666 / opensap_python_intro

This repository contains several Jupyter notebooks. These notebooks are the course material for an upcoming openSAP course on Python 🐍.
Creative Commons Zero v1.0 Universal
5 stars 1 forks source link

Notebooks #161

Closed GlennVerhaag closed 2 years ago

GlennVerhaag commented 2 years ago

I've found some feedback regarding the notebooks:

  1. There's a small typo in the notebook for Week 1, Unit 5: "" -> "=="
  2. The wording in the notebook for Week 4, Unit 3 is incorrect: "The result is a list with one entry." -> "The result is a list with one entry for each line in the file."
  3. There was a lot of confusion regarding the "numbers2.txt" file in the notebook for Week 4, Unit 3. The file is included in the "Download all Notebooks" zip-file, but not in the zip-file below the video for this unit.
Hiltiprant commented 2 years ago

@SusanneBusemann Should we correct the issues already or do we leave this here for documentation purposes til the end of the course?

SusanneBusemann commented 2 years ago

Just aligned with Stephan and Christian - we correct the ones from Week 5 immediately (issue 164) but the ones from former weeks we collect & store here and update at a later point in time.

SusanneBusemann commented 2 years ago

@stjaco62 @ceedee666 Was there any reason to not include "numbers2.txt" in the notebook for Week4, Unit 3? I only got the order to include lorem_ipsum.txt. I´m fine with updating the .zip once more underneath the video to include the other one, just let me know.

SusanneBusemann commented 2 years ago

@GlennVerhaag @kaisdeljam @simonfreud @LauritsE98 @Hiltiprant The file "numbers2.txt" is now also included in the zip file below the video of Week 4 Unit 3. Next time please inform me directly when someone complains, we can always add files if they are missing. It would be great if you could answer in respective forum threads that this is available now, even if they already found the workaround by other users who sent the file, or via "All notebooks".

SusanneBusemann commented 2 years ago

Above mentioned notebooks are all exchanged. We can keep this thread open until the end in case we find more errors in the notebooks.

Hiltiprant commented 2 years ago

Now we have the end, so I am closing. I like closing issues btw 😄