cees-elzinga / script.xbmc.hue.ambilight

XBMC add-on for Philips Hue lights with ambilight support
Do What The F*ck You Want To Public License
127 stars 123 forks source link

HueAmbilight Script error #15

Closed broekp closed 10 years ago

broekp commented 10 years ago

Update: Turned off the Flashlights setting to surpress the error and plugin then works.

Ambilight plugin does not work, logfile shows following: Note other Hue plugin where bulbs are dimmed on startup do seem to work correctly.

22:25:36 T:2838436720 NOTICE: -->Python Interpreter Initialized<-- 22:25:36 T:2838436720 NOTICE: XBMC Hue service started, version: 0.6.0 22:25:36 T:2838436720 NOTICE: XBMC Hue: DEBUG class Hue: update settings 22:25:36 T:2838436720 NOTICE: XBMC Hue: DEBUG bridge_ip: 10.0.0.2 bridge_user: d3e55f3666016cc15470bc3a43676535 mode: 0 light: 3 light1_id: 1 light2_id: 2 light3_id: 3 group_id: 0 misc_initialflash: True dimmed_bri: 50 undim_bri: 203 dimmed_hue: 22755 override_hue: False undim_hue: 22755 ambilight_dim: False ambilight_dim_group: 0 ambilight_min: 0 ambilight_max: 228 color_bias: 18 debug: True 22:25:36 T:2838436720 NOTICE: XBMC Hue: DEBUG creating Light instances 22:25:36 T:2838436720 NOTICE: XBMC Hue: DEBUG class Hue: flashing lights 22:25:36 T:2838436720 NOTICE: XBMC Hue: DEBUG set_light: 1: {"on":true,"bri":50,"transitiontime":4} 22:25:36 T:2838436720 ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--

cees-elzinga commented 10 years ago

Thanks for the debug logging.

Do you have any other lights then "philips hue"? Maybe "living colour" lights?

--> KeyError: ('hue',) seems to suggest it tries to change the hue setting of a light that does not support "hue".

then it would be a bug in the code... (the briger_light() probably doesnt check what kind of light it is and always sets a hue value)

broekp commented 10 years ago

Hi Cees,

Indeed i have a livingwhites cfli bulb in my setup. After removing the flashlights setting in the config your plugin works. Will check if it is the first bulb in the config settings as looking at your code seems to refer to that one.

Nice job on the plugin. Op 18 aug. 2013 11:57 schreef "cees-elzinga" notifications@github.com het volgende:

Thanks for the debug logging.

Do you have any other lights then "philips hue"? Maybe "living colour" lights?

--> KeyError: ('hue',) seems to suggest it tries to change the hue setting of a light that does not support "hue".

then it would be a bug in the code... (the briger_light() probably doesnt check what kind of light it is and always sets a hue value)

— Reply to this email directly or view it on GitHubhttps://github.com/cees-elzinga/script.xbmc.hue.ambilight/issues/15#issuecomment-22827810 .

cees-elzinga commented 10 years ago

Check. The "flashing lights" part of the code didn't check if a lights was a livingwhite light, and tried to adjust the hue setting. That caused the crash you described.

Workaround was indeed to disable the initial flashing of the lights.

I pushed an update (version 0.6.1) that should fix the issue. Also, the new version let's you control the dim/undim times from the advanced settings panel (thanks to ChrisRegado)

It's difficult for me to test because I don't own livingwhite bulbs, so if you could test the new version?

broekp commented 10 years ago

Hi Cees,

I will check the version tonight and let you know to close the ticket.

Cheers, Paul Op 18 aug. 2013 15:03 schreef "cees-elzinga" notifications@github.com het volgende:

Check. The "flashing lights" part of the code didn't check if a lights was a livingwhite light, and tried to adjust the hue setting. That caused the crash you described.

Workaround was indeed to disable the initial flashing of the lights.

I pushed an update (version 0.6.1) that should fix the issue. Also, the new version let's you control the dim/undim times from the advanced settings panel (thanks to ChrisRegado)

It's difficult for me to test because I don't own livingwhite bulbs, so if you could test the new version?

— Reply to this email directly or view it on GitHubhttps://github.com/cees-elzinga/script.xbmc.hue.ambilight/issues/15#issuecomment-22830103 .

cees-elzinga commented 10 years ago

No update from broekp

Issue is related to #18, and got feedback there the issue is solved. Closing.