cefayefang / Justus-von-Liebig-

0 stars 0 forks source link

James Lind Code Review #1

Open manutdftw21 opened 6 months ago

manutdftw21 commented 6 months ago

Noticed this issue when running the notebook. I believe this is a downcasting error, where the units aren't lining up when you are converting in the code for this part.

Screen Shot 2024-03-04 at 8 41 38 PM

Other than that, the code follows the guideline code really well and the topic definitely seems very interesting. Excited to see where this project ends up. I also like the different visualizations, I feel like they are relevant to your topic which is great to see.

cefayefang commented 6 months ago

Hi,

Thank you for reviewing our code and for your feedback. I want to assure you that despite the warning, the code functions correctly and meets the expected outcomes. We appreciate your positive comments on the visualizations and the project's direction. Thank you again for your time. We're looking forward to presenting our final work.