search

cefayefang / Justus-von-Liebig-

0 stars 0 forks source link

review from team Harriette Chick #2

Open chrisgnicholas opened 8 months ago

chrisgnicholas commented 8 months ago

a) it was unclear how to satisfy the python module requirements to run the notebook. I am in VSCode, and tried just creating a virtual environment using the requirements.txt, but ran into several issues that I had to resolve manually (matplotlib, seaborn,

b) references to a private APIkey should be replaced with "YOUR_API_KEY" or something similar

After that things ran nicely. I liked the extra comparison plots to highlight differences between pricing.

cefayefang commented 8 months ago

Hi, Thank you for taking the time to review our code. It might be easier to use the datahub link provided by us which should clone everything into your datahub and run correctly. But for sure, we will improve our code instructions next time for VSCode or other environments. Also, we will definitely change our own API key to "YOUR_API_KEY" instruction word for privacy. Thank you again.