search

ceff-tech / ffc_api_client

An R client for the online Functional Flows Calculator API
https://ceff-tech.github.io/ffc_api_client
9 stars 3 forks source link

add argument to turn off plotting in evaluate_alteration function #31

Open ryanpeek opened 4 years ago

ryanpeek commented 4 years ago

just a note for batch processing, we probably need to turn off the plotting option. Default can be that plotting occurs, but should add argument for plotting=FALSE to allow just the data to get pulled in...and then maybe option to run plotting function separately? I can work on this but wanted to remember.

nickrsan commented 4 years ago

Yeah, I think that makes sense - I think these two functions should remain as the core shortcut functions that go through the whole workflow, so being able to disable certain aspects while going through the rest makes sense so that the alternative isn't to basically recreate the function without that one thing. Noted!

nickrsan commented 4 years ago

I'm going to add the high priority label to this so that we can have it ready in time to do the next set of batching.

nickrsan commented 4 years ago

Added to evaluate_gage_alteration in d09b8f00b16c8a2aded7f4e0089522110950f3ef, but still want to add it to evaluate_alteration to have a consistent API between the two.