search

ceff-tech / ffc_api_client

An R client for the online Functional Flows Calculator API
https://ceff-tech.github.io/ffc_api_client
9 stars 3 forks source link

Boxplots for predicted FA_Dur, SP_ROC, all Peak_Dur, all Peak_Fre are split into two #49

Closed kristaniguchi closed 4 years ago

kristaniguchi commented 4 years ago

Boxplots for predicted FA_Dur, SP_ROC, all Peak_Dur, all Peak_Fre are split into two. Please plot only one boxplot for those predicted metrics Peak_Fre

nickrsan commented 4 years ago

Huh - I haven't seen this behavior - I see the COMID you used there, but am not sure if this is a gage, or using your own timeseries - was this when using the data/code you sent me previously, or something else? Just wondering so I can reproduce it and figure out where the bug is.

kristaniguchi commented 4 years ago

Yes, using the code i sent you and my own gage data for observed ffcAPIClient::evaluate_alteration()

nickrsan commented 4 years ago

OK, traced this problem to a data issue from the flows API related to the predicted flow metrics producing duplicate values. I'm going to have it deduplicate, but it's not an exact process because sometimes the values are different.

nickrsan commented 4 years ago

As an addendum, this probably only showed up recently because we used to use internal data that we'd deduplicated, but we switched to the flow API about a month ago. I'm in touch with Kirk about it too in case they want to address it themselves - I reported it to Ted last year.

nickrsan commented 4 years ago

OK, resolved this issue in commit a7fd8671fe28af1fded1d0dc390c00c330da8b6b

Kris, whenever you get a chance, can you upgrade and let me know if you encounter this issue or any new errors? I'm closing it for now, but please reopen it if a related bug still exists.

kristaniguchi commented 4 years ago

Thanks, Nick! Works great.

Kris

-- Kris Taniguchi-Quan, PhD Scientist Southern California Coastal Water Research Project 3535 Harbor Blvd, Suite 110https://maps.google.com/?q=3535+Harbor+Blvd,+Suite+110+%0D%0A+Costa+Mesa,+CA+92626+%0D%0A+Office:+(714&entry=gmail&source=g Costa Mesa, CA 92626https://maps.google.com/?q=3535+Harbor+Blvd,+Suite+110+%0D%0A+Costa+Mesa,+CA+92626+%0D%0A+Office:+(714&entry=gmail&source=g Office: 714https://maps.google.com/?q=3535+Harbor+Blvd,+Suite+110+%0D%0A+Costa+Mesa,+CA+92626+%0D%0A+Office:+(714&entry=gmail&source=g-755-3221 kristinetq@sccwrp.orgmailto:kristinetq@sccwrp.org www.sccwrp.orghttp://www.sccwrp.org/

SCCWRP’s response to COVID-19: Read the full statementhttps://www.sccwrp.org/sccwrp-response-to-covid-19

From: Nick Santos notifications@github.com Sent: Wednesday, March 11, 2020 2:43 PM To: ceff-tech/ffc_api_client ffc_api_client@noreply.github.com Cc: Kristine Taniguchi-Quan kristinetq@sccwrp.org; Author author@noreply.github.com Subject: Re: [ceff-tech/ffc_api_client] Boxplots for predicted FA_Dur, SP_ROC, all Peak_Dur, all Peak_Fre are split into two (#49)

OK, resolved this issue in commit a7fd867https://github.com/ceff-tech/ffc_api_client/commit/a7fd8671fe28af1fded1d0dc390c00c330da8b6b

Kris, whenever you get a chance, can you upgrade and let me know if you encounter this issue or any new errors? I'm closing it for now, but please reopen it if a related bug still exists.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ceff-tech/ffc_api_client/issues/49#issuecomment-597892730, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACTCCYB2OMSBMNQQWWCXQIDRHAAWTANCNFSM4LBQM5XA.