ceff-tech / ffc_api_client

An R client for the online Functional Flows Calculator API
https://ceff-tech.github.io/ffc_api_client
9 stars 3 forks source link

Do not plot Peak_Tim metrics boxplots #50

Open kristaniguchi opened 4 years ago

kristaniguchi commented 4 years ago

Peak timing metrics are no longer included as functional flow metrics. Do not create boxplots for them.

nickrsan commented 4 years ago

Just acknowledging this one - I'll drop those metrics.

kristaniguchi commented 4 years ago

Thanks!

nickrsan commented 4 years ago

Hey @alyssaobester and @ryanpeek before I drop these metrics, can you confirm that you don't have a use case for them where I should make it an option to include or not include them in plotting?

Also, should they be dropped completely (ie, not in the data frames either) and not just from plotting?

ryanpeek commented 4 years ago

This is fine by me. I don't think they would be needed in the dataframe either, but fairly easy to remove after downloading as well.