search

ceff-tech / ffc_api_client

An R client for the online Functional Flows Calculator API
https://ceff-tech.github.io/ffc_api_client
9 stars 3 forks source link

evaluate_alteration(), evaluate_gage_alteration(), and get_predicted_flow_metrics() not working #56

Closed kristaniguchi closed 4 years ago

kristaniguchi commented 4 years ago

Hi Nick, last week these functions (evaluate_alteration(), evaluate_gage_alteration(), and get_predicted_flow_metrics()) were working fine. Now they no longer work (with same data/script) and give the following error after saving the DRH step: [1] "Saving DRH to..." Error in rbind(deparse.level, ...) : numbers of columns of arguments do not match

I uninstalled and reinstalled the ffc api but still getting the same error. Did something change in the code? Thanks!

kklausmeyer commented 4 years ago

Hi all- we updated the functional flow API to include three new fields- this may be causing an error in the get_predicted_flow_metrics() code. To see the new schema with observed data added, use this URL for an example: https://flow-api.codefornature.org/v2/ffm/?comids=15048349

nickrsan commented 4 years ago

Thanks Kirk - I was wondering if something changed in one of the APIs given the error here - I appreciate you chiming in here so quickly (and I know I owe you some email responses too!).

Kris, I'm readying some other changes to help make the package nicer for CEFF users, so I'll make the appropriate changes to fix this and include them in an update and let you know here once that's done today or tomorrow.

kristaniguchi commented 4 years ago

Sounds good! Thanks, Kirk and Nick!

nickrsan commented 4 years ago

Hi Kris,

I believe I incorporated the required fixes in the latest commit, along with other code. Please try again. I'm going to close this issue, but please reopen it if you still have problems.

The fix was included in f18833d72b70ad514ecaf054c2fc6184922cc286

kristaniguchi commented 4 years ago

Thanks, Nick! Really appreciate all you’ve done for CEFF 😊 Good like at UC Merced!

Kris

-- Kris Taniguchi-Quan, PhD Scientist Southern California Coastal Water Research Project 3535 Harbor Blvd, Suite 110https://maps.google.com/?q=3535+Harbor+Blvd,+Suite+110+%0D%0A+Costa+Mesa,+CA+92626+%0D%0A+Office:+(714&entry=gmail&source=g Costa Mesa, CA 92626https://maps.google.com/?q=3535+Harbor+Blvd,+Suite+110+%0D%0A+Costa+Mesa,+CA+92626+%0D%0A+Office:+(714&entry=gmail&source=g Office: 714https://maps.google.com/?q=3535+Harbor+Blvd,+Suite+110+%0D%0A+Costa+Mesa,+CA+92626+%0D%0A+Office:+(714&entry=gmail&source=g-755-3221 kristinetq@sccwrp.orgmailto:kristinetq@sccwrp.org www.sccwrp.orghttp://www.sccwrp.org/

From: Nick Santos notifications@github.com Sent: Thursday, April 23, 2020 1:34 PM To: ceff-tech/ffc_api_client ffc_api_client@noreply.github.com Cc: Kris Taniguchi-Quan kristinetq@sccwrp.org; Author author@noreply.github.com Subject: Re: [ceff-tech/ffc_api_client] evaluate_alteration(), evaluate_gage_alteration(), and get_predicted_flow_metrics() not working (#56)

Hi Kris,

I believe I incorporated the required fixes in the latest commit, along with other code. Please try again. I'm going to close this issue, but please reopen it if you still have problems.

The fix was included in f18833dhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fceff-tech%2Fffc_api_client%2Fcommit%2Ff18833d72b70ad514ecaf054c2fc6184922cc286&data=01%7C01%7Ckristinetq%40sccwrp.org%7Cf23cfa60aee2487bbb5008d7e7c59e9a%7Ca4a8f23d1ae14b1c9902eaa153028190%7C0&sdata=zlseiuAQ2tIEMNM%2F9WClssfMqy33wPenkeOa8IVWfqk%3D&reserved=0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fceff-tech%2Fffc_api_client%2Fissues%2F56%23issuecomment-618652380&data=01%7C01%7Ckristinetq%40sccwrp.org%7Cf23cfa60aee2487bbb5008d7e7c59e9a%7Ca4a8f23d1ae14b1c9902eaa153028190%7C0&sdata=LfG4ls1p%2BPF6dXFlVJQpfMwUlYZqJ%2FBvJwT46CEoXTs%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FACTCCYELEH2HZF4NHAJKKQ3ROCQ2RANCNFSM4MOTA7MA&data=01%7C01%7Ckristinetq%40sccwrp.org%7Cf23cfa60aee2487bbb5008d7e7c59e9a%7Ca4a8f23d1ae14b1c9902eaa153028190%7C0&sdata=UPEyRv4vbT4kxoBh8sOvCfB64p1nlz8rVLdEddGR7iA%3D&reserved=0.