search

ceff-tech / ffc_api_client

An R client for the online Functional Flows Calculator API
https://ceff-tech.github.io/ffc_api_client
9 stars 3 forks source link

update function again to fix different year types #74

Closed ryanpeek closed 1 year ago

ryanpeek commented 2 years ago

Previously only worked for "all" year types, now should filter out non-modeled/inferred predicted FF metrics for any/all year types.

Also rebuilt documentation and version pdf.

nickrsan commented 1 year ago

Hey @ryanpeek - hope the new job is treating you well! Do you know anything about the status of this pull request? I see I was a suggested reviewer and probably this was just waiting on me reviewing? From what I can see, it should be fine to merge, but I wanted to see if you remembered any reason you held off on the merge.

I'm checking in partially because @kristaniguchi and a new grad student at CWS are going to be doing a bit more work in this in the coming days, so I want to make sure everything is consistent before starting. Thanks and I hope your family is well!

ryanpeek commented 1 year ago

Hi @nickrsan! wow I completely forgot about this...I think it was something folks talked about adding, but this definitely dropped off my radar. I'm merging now and can keep tabs on this a bit more in the coming weeks. Alyssa keeps me posted on much of this (and Sarah), so hopefully can keep it going and help out if needed.

Hopefully this helps get everything sorted and up-to-date before the next wave of work.