cefn / watchable

Repo for @watchable/store and supporting packages.
MIT License
5 stars 1 forks source link

Consider aligning with Immer 'Immutable' type definition #34

Closed cefn closed 10 months ago

cefn commented 1 year ago

As I recall, we kept to our own watchable type definition for Immutable because the vendor Immutable definitions we tried to use were routinely causing stack overflows in the compiler... https://github.com/ts-essentials/ts-essentials/issues/194

It's worth trying the version from Immer, especially since improvements in Typescript could eliminate some of this explosion. It also has an inverse operation (Draft). See https://github.com/immerjs/immer/blob/main/src/types/types-external.ts#L51

cefn commented 10 months ago

Completed in https://github.com/cefn/watchable/pull/42