Unable to customise path for the crash dump process (crashpad) - Githubissues

cefsharp / CefSharp

.NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework

http://cefsharp.github.io/

Other

9.89k stars 2.92k forks source link

Unable to customise path for the crash dump process (crashpad) #1876

Closed merceyz closed 7 years ago

merceyz commented 8 years ago

What version of the product are you using?
- 55.0.0-CI2067
What architecture x86 or x64?
- x64
On what operating system?
- Win7
Are you using WinForms, WPF or OffScreen?
- OffScreen
What steps will reproduce the problem?
- Enumerate through the string[] "args" in Program.Main and write them out to the console then call Cef.Initialize();
What is the expected output? What do you see instead?
- The expected output is the first three lines, the rest is the unexpected part.
Please provide any additional information below.
- I updated from CI2055 to CI2067, the issue was not present before the update.
- Seems like CefSharp or Cef is calling Program.Main instead of whatever it's supposed to call
- debug.log:
```
[1201/221400:ERROR:file_io.cc(30)] read: expected 4, observed 0
[1201/221400:ERROR:registration_protocol_win.cc(53)] CreateFile: The system cannot find the path specified. (0x3)
```

merceyz commented 8 years ago

I went through each MyGet package starting at CI2055. The issue first happens in CI2065

amaitland commented 7 years ago

The relevant upstream issue is https://bitbucket.org/chromiumembedded/cef/issues/1995/migrate-from-breakpad-to-crashpad

As yet there is no way to customise the new crashpad process. Short term workaround is to use your main process to host crashpad, an example was added see https://github.com/cefsharp/CefSharp/commit/8970196740d5337a47b246518815ee8849cba90f

amaitland commented 7 years ago

The CEF issue needs to be resolved before 55.0.0 can be released.

amaitland commented 7 years ago

Issue has been resolved upstream, hopefully the changes will be merged into the 2883 branch shortly.

https://bitbucket.org/chromiumembedded/cef/issues/1995/migrate-from-breakpad-to-crashpad#comment-33539720

amaitland commented 7 years ago

If "AppName" is set on Windows then crash report information (metrics, database and dumps) will be stored locally on disk under the "C:\Users[CurrentUser]\AppData\Local[AppName]\User Data" folder. On other platforms the CefSettings.user_data_path value will be used.

Looks like crashpad will be disabled unless a crash_reporter.cfg is present. The examples will be updated to enable crashpad, if no server url is specified the crash reports will be generated on disk. We'll go with this option for testing purposes.

amaitland commented 7 years ago

Crashpad is now disabled by default. I have been unable to get it working with the examples, that's a different problem.

amaitland commented 7 years ago

crashpad process spawns successfully when running outside of Visual Studio, likely a problem caused by the vshost process.

amaitland commented 7 years ago

You can use https://github.com/cefsharp/CefSharp.MinimalExample/tree/cefsharp/55 for testing. Likely you just need to perform a full cleanup (exit out of VS and do a git clean -fx). VS gets confused from time to time.

merceyz commented 7 years ago

I removed the comment because I found the issue, didn't want to waste your time, wasn't fast enough.

The issue was that the cef.redist.x64 files wasn't getting copied by nuget, did it manually and that fixed the crash.

The problem this issue was created for is then solved and this can be marked as such. Thanks