Nuget - Remove netcoreapp3.0 hacks

cefsharp / CefSharp

.NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework

http://cefsharp.github.io/

Other

9.79k stars 2.92k forks source link

Nuget - Remove netcoreapp3.0 hacks #3444

Closed amaitland closed 2 years ago

amaitland commented 3 years ago

As a temporary workaround whilst .Net Core 3.1/.Net 5.0+ support was being implemented some hacks were implemented to make the CefSharp.Wpf/CefSharp.WinForms/CefSharp.OffScreen packages work easily with .Net Core 3.0. Now that we have a new set of packages and .Net Core 3.0 is out of support we should remove the hacks. This will greatly reduce the size (approx 5mb reduction in size of CefSharp.Common as it has duplicate files).

IMPORTANT

Anyone targeting .Net Core 3.1/.Net 5.0+ using these older packages will either need to migrate to the newer packages or try setting AssetTargetFallback
For those targeting .Net Core 3.0 which are unable to upgrade to .Net Core 3.1 or greater then the old packages should still be usable by specifying AssetTargetFallback

amaitland commented 2 years ago

Once .Net 6.0 is released (the next LTS version) I'll remove the hacks, looks like that'll be sometime in November

amaitland commented 2 years ago

I need to resolve #3706 which is blocked on this issue so I'm attaching this to the 95 milestone. Little ahead of my original plan unfortunately.

amaitland commented 2 years ago

For .Net Core 3.1/.Net 5.0+ use the following packages:

It is recommended that you set a <RuntimeIdentifier/> during development, adding the following to your project file <RuntimeIdentifier Condition="'$(RuntimeIdentifier)' == ''">$(NETCoreSdkRuntimeIdentifier)</RuntimeIdentifier> will use the default for your operating system. Please read https://github.com/cefsharp/CefSharp/issues/3284#issuecomment-772132523 for more information.
For .Net Core/.Net 5.0+ the Ijwhost.dll file is required. To support C++/CLI libraries in .NET Core, ijwhost was created as a shim for finding and loading the runtime. All C++/CLI libraries are linked to this shim, such that ijwhost.dll is found/loaded when the C++/CLI library is loaded.