cefsharp / CefSharp

.NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework
http://cefsharp.github.io/
Other
9.76k stars 2.92k forks source link

WPF - Ensure only single drag operation is emit on DragSourceEndedAt #4814

Closed WilliamTomOBrien closed 3 weeks ago

WilliamTomOBrien commented 1 month ago

Fixes: #4801

Summary:

Changes:

How Has This Been Tested?

This has been tested by going through the same process detailed in the issue here. This was done on Windows 11, with an x64 architecture, .NET Version 4.7.2, and the WPF implementation.

Types of changes

Checklist:

AppVeyorBot commented 1 month ago

:white_check_mark: Build CefSharp 125.0.80-CI5005 completed (commit https://github.com/cefsharp/CefSharp/commit/fcd1f2ff91 by @WilliamTomOBrien)

amaitland commented 1 month ago

Thanks for the PR 👍

We should compare this to the cefclient reference implementation.

amaitland commented 3 weeks ago

Some quick testing and this look ok 👍 It probably needs more thorough testing though.

Rather than let it sit here I'll extract the logic out into a method and allow for customisation of the behaviour.

Someone can implement their own custom logic (or revert to the previous behaviour if they wanted).

Follow up PR #4845