Closed WilliamTomOBrien closed 3 weeks ago
:white_check_mark: Build CefSharp 125.0.80-CI5005 completed (commit https://github.com/cefsharp/CefSharp/commit/fcd1f2ff91 by @WilliamTomOBrien)
Thanks for the PR 👍
We should compare this to the cefclient reference implementation.
Some quick testing and this look ok 👍 It probably needs more thorough testing though.
Rather than let it sit here I'll extract the logic out into a method and allow for customisation of the behaviour.
Someone can implement their own custom logic (or revert to the previous behaviour if they wanted).
Follow up PR #4845
Fixes: #4801
Summary:
none
,move
,copy
, orlink
can be passed the the browser host to signify a DragEnd event. Specifying multiple flags on the bitmask seems to prevent the event from firing, and therefore the result that is returned from DragDrop.DoDragDrop is compared to the last drag drop effect we have on record.none
,move
,copy
, orlink
flags by themselves in the bitmask, and seemed to correlate with the event'sdataTransfer.dropEvent
field. Given the API specifies that can only be one of those four values (and not a mixture of them), that seemed reasonable. Furthermore, it seemed that theDoDragDrop
function used within theStartDragging
function would consistently return the mask with more than one value set.Changes:
How Has This Been Tested?
This has been tested by going through the same process detailed in the issue here. This was done on Windows 11, with an x64 architecture, .NET Version 4.7.2, and the WPF implementation.
Types of changes
Checklist: