search

cefsharp / CefSharp

.NET (WPF and Windows Forms) bindings for the Chromium Embedded Framework
http://cefsharp.github.io/
Other
9.88k stars 2.92k forks source link

Test - Use TaskCreationOptions instead of TaskContinuationOptions for TaskCompletionSource #4942

Closed campersau closed 1 month ago

campersau commented 1 month ago

Using TaskCreationOptions instead of TaskContinuationOptions for TaskCompletionSource in test. This was the only place where it was wrong.

AppVeyorBot commented 1 month ago

:x: Build CefSharp 128.4.90-CI5064 failed (commit https://github.com/cefsharp/CefSharp/commit/08bfe32a52 by @campersau)

amaitland commented 1 month ago

Thanks! We should probably install the analyzers packages in all the relevant csproj files and set CA2247 as error going forward

amaitland commented 1 month ago

Have added the analyzer packages is commit https://github.com/cefsharp/CefSharp/commit/17269dc648217ae85a05a07fbafa9b692b386a6e

Unfortunately GlobalPackageReference looks like it requires VS2022, so have had to add the references manually.

Haven't added any rules yet.