search

cefsharp / cef-binary

NuGet repackaging of the CEF binaries provided by Chromium Embedded Framework
https://cef-builds.spotifycdn.com/index.html
Other
110 stars 87 forks source link

$Configuration$ and $Platform$ package variant building #10

Closed jornh closed 10 years ago

jornh commented 10 years ago

As proposed in https://github.com/cefsharp/CefSharp/issues/350

NOTE: This is experimental for now - and for it to pack right now it depends on that you manually copy /cef_binary_3.y.z_windows[32|64][Release|Debug] to ...[x86|x64]...

amaitland commented 10 years ago

@jornh Looking at this now, wondering how this will work for the CefSharp project it's self. For example, building for x86 and then switching to x64?

In theory, I think it's an excellent idea to split them so you only get what's required, just unsure how that works for the CefSharp project where we require both?

jornh commented 10 years ago

You should be able to install both simultaneously. It's a valid use case in general as some also might want both for other applications than the CefSharp.Xxx.Example ones.

Right now the Examples use a .props file in the root folder. It might need a simple adjustment to where in the path $platform$ is.

amaitland commented 10 years ago

Sounds promising. I was tinkering with this last night, is there any particular part you'd class as experimental?

Also are these References relevant? https://github.com/amaitland/cef-binary/blob/properties-based-cef.redist-variations/NuGet/cef.sdk.props#L4

jornh commented 10 years ago

cef.sdk.props are referenced from https://github.com/cefsharp/CefSharp/blob/master/CefSharp.Core/CefSharp.Core.vcxproj#L126 So it's all related to the cef.sdk NuGet which carry the .lib and include files only relevant for building the CefSharp binding

There is no relation to this PR which is only concerned with cef.redist (DLLs and .pak files used by applications building on CefSharp)

I think we can worry about cef.sdk separately after this. Trying to juggle both at the same time has a tendency to induce dizziness bordering to a feeling of sea-sickness (at least that's the effect it has on me :stuck_out_tongue_winking_eye:)

Hmm maybe the experimental label isn't a good expression of what I meant. It's just that it needs a bit of reviewing to make sure we covered all the bases, like the concern you raised with "does it allow one to build both 32 bit and 64 in the same project?". At the time I submitted the PR I was afraid that I wasn't able to review it myself properly, that I has just fallen to much in love with my own idea. Now that it has been sitting there for a while I might be able to do a better job at it again. But by all means kick the tires on it and see if you can find any blind spots.

jornh commented 10 years ago

Closing this in favor of #14