search

cefsharp / cef-binary

NuGet repackaging of the CEF binaries provided by Chromium Embedded Framework
https://cef-builds.spotifycdn.com/index.html
Other
110 stars 87 forks source link

Fix formatting #61

Closed perlun closed 6 years ago

perlun commented 6 years ago

I had some spare time while waiting for a CEF/Chromium build (...) so I fixed this. As a side effect of the change, I also removed the debug building completely - it just takes time, we don't use the resulting artifacts anyway. So it makes more sense to only build Release builds of this repo.

Closes #60

AppVeyorBot commented 6 years ago

:white_check_mark: Build cef-binary 62.0.0-CI31 completed (commit https://github.com/cefsharp/cef-binary/commit/05a546cad9 by @perlun)

AppVeyorBot commented 6 years ago

:white_check_mark: Build cef-binary 62.0.0-CI34 completed (commit https://github.com/cefsharp/cef-binary/commit/05a546cad9 by @perlun)

perlun commented 6 years ago

r? @merceyz

perlun commented 6 years ago

@amaitland Thanks for the constructive feedback. You are right, it's much better to segregate changes instead of messing it up like this, my bad.

Please re-check at your convenience, the PR should be much better now.

perlun commented 6 years ago

Thanks for the review & approval @amaitland, appreciated! I moved the discussion around the functional changes to #63, so we can get them incorporated also in a proper manner.